Repository navigation
test: expand module regressions beyond 95% local line coverage - #58
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 88.79% 95.82% +7.03%
==========================================
Files 127 127
Lines 29649 29751 +102
==========================================
+ Hits 26326 28510 +2184
+ Misses 3323 1241 -2082 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Unpinned `choco install mysql` resolved to 26.10.0 and aborted mid-download from cdn.mysql.com (connection reset / 404) before compile. Pin Approved package 9.6.0, whose zip is still served, and retry transient CDN failures. macOS Homebrew MySQL starts with an empty root password. The workflow only detected that and created database test, so new tests that require the documented root/root credentials never became healthy and exhausted their wait loops. Set root/root and create the test database, matching Linux and Windows.
test_crypto calls OpenSSL APIs directly, and fakelua.dll is built with -Wl,--exclude-libs,ALL so those symbols are not re-exported. unit_tests must therefore link OpenSSL::SSL and OpenSSL::Crypto itself. Mark the imported targets IMPORTED_GLOBAL so test/ can use src/'s find_package result without a second lookup that would miss the MinGW policy.
Windows CI failed 2 of 1824 tests on c4e5f27. MakeClientContext ignored SSL_CTX_load_verify_locations failures, so a missing tls_ca still started a connect to the default 127.0.0.1:8888. Linux often surfaces ECONNREFUSED on the first poll; Windows does not, and closed stayed 0. Fail the context when a specified CA cannot be loaded so Connect() emits Close without starting a connection. packsize("!8bXll") == 16 holds only when sizeof(long) is 8. On Windows LLP64, long is 4 bytes and the size is 8. Keep the X-alignment checks and compute the expected size from the native item sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_coverage/cov_gapsnaming, private PackSpec exposure, coverage-only hooks, denominator exclusions, or dead-code deletion.Real regressions repaired
Validation on the exact committed source
--oncechecks (exit 0).--initial) does not treat old unloaded generated-C images' gcno files as executed; old artifacts remain preserved locally. Instrumented generated images are freshly owned, not reused from prior runs.src/*,include/*,build-cov/jit_cov/*,--no-external; existing lcov error tolerances retained, no exclusions added..clang-format, clang-format 21.1.8: all 39 changed C/C++ files pass dry-run/Werror;git diff --checkpasses. New C++ case names and Lua filenames/function names were audited for descriptive module placement.Repository hygiene
5ae28f02c02c581941180ee0e7391d24e7ec9d1bbefore push.esrrhs <esrrhs@163.com>.