fix: add stabilization detector to bee struct#5414
Merged
akrem-chabchoub merged 2 commits intomasterfrom Mar 31, 2026
Merged
Conversation
…r closure during shutdown
akrem-chabchoub
requested review from
acud,
gacevicljubisa,
janos,
martinconic and
sbackend123
acud
approved these changes
Mar 30, 2026
Contributor
acud
left a comment
acud
left a comment
There was a problem hiding this comment.
LGTM. Please just fix the PR name (this is not a feature, but fix), and make it shorter so there's no text ellipsis.
Refresher on conventional commits
akrem-chabchoub
changed the title
gacevicljubisa
approved these changes
Mar 31, 2026
martinconic
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Problem: The warmup detector was built during startup but
defer detector.Close()ran whenNewBeereturned, so it reset to idle while the rest of the node kept using it. The next real traffic restarted monitoring from zero, so warmup could finish twice and readiness looked wrong.Fix: Align detector lifetime with the node: keep it on Bee, drop the deferred close in NewBee, and call
Close()only inShutdown(). That way warmup state stays valid for the whole run and you avoid a second warmup cycle caused by the accidental reset.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#5413
Screenshots (if appropriate):
AI Disclosure