Repository navigation
fix(cli): read token expiry as epoch seconds in auth status - #257
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
line auth statusreportsexpiresAtin January 1970 andexpired: trueright after a successful QR login, even though the session works.Cause
tokenExpiry()inpackages/cli/src/profile-store.tstreatsstorage.expireas milliseconds since the epoch. The login code inpackages/linejs/base/login/mod.tsstorestokenInfo[3] + tokenInfo[6], which is in epoch seconds, so the value is read ~1000x too small.Fix
Minimal CLI-side fix: values below
1e12are treated as epoch seconds and converted to milliseconds before building the date and computingexpired. Millisecond values are still accepted, so nothing breaks if the storage format ever changes. The library's storage format is untouched, and the misleading comment is corrected.Tests
packages/cli/test/profile-store.test.tscovering seconds/milliseconds as numbers and strings (past/now/future with a mocked clock), and missing/invalid values.cd packages/cli && pnpm exec vp test: 53 passed.pnpm --filter @evex-dev/linejs-cli run typecheckandpnpm exec vp check: no errors.{"expiresAt":"1970-01-21T…","expired":true}; after the fix the expiry is a date a few days in the future withexpired: false.Checklist