Repository navigation
fix(cli): support user (1:1) chats in messages commands - #258
Merged
Merged
Conversation
talk.getChat only serves group/room chats, so user mids failed with Chat({raw: undefined}). Route u... mids through the message-box APIs (getMessageBoxes + getPreviousMessagesV2WithRequest + TalkMessage.fromRawTalk) shared by chats messages and messages show/pin/data. Group/room behavior is unchanged.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
line chats messages <mid>andline messages show <mid> <messageId>crashed for 1:1 (user) mids withCannot read properties of undefined (reading 'chatMid').Cause:
resolveTalkMessageandchats messagescalledclient.getChat(mid), which wrapstalk.getChat— a group/room-only API. For user mids it yields no chat, so constructingChatfromundefinedblew up.This PR routes
u...mids through the message-box APIs instead (getMessageBoxesto find the box,getPreviousMessagesV2WithRequestfor history,TalkMessage.fromRawTalkfor E2EE decryption), shared via newfetchTalkMessages/fetchUserTalkMessageshelpers inpackages/cli/src/commands/shared.ts. Group/room behavior is unchanged.Checklist
messages showcall against a 1:1 chat decrypted the text successfully; content omitted)