Repository navigation
fix(request): keep response headers and body out of errors - #261
Open
stickerdaniel wants to merge 1 commit into
Open
stickerdaniel wants to merge 1 commit into
stickerdaniel wants to merge 1 commit into
Conversation
A response that failed to parse as Thrift threw an error naming every response header and the body as hex. An object ID mismatch in uploadMediaByE2EE put every response header into its message and data. Those headers include x-line-next-access, the next access token, and callers log and print error messages. The parse error now names the status, method and body length. The object ID mismatch error names both object IDs.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A response that fails to parse as Thrift, such as a gateway error page, threw an error with every response header and the body as hex. One of those headers is
x-line-next-access, the next access token. Callers log and print error messages, and the CLI copiesmessageandstackinto its JSON errors and MCP tool output.The parse error now names the status, method and body length:
Request internal failed: status=503 method=getProfile bodyLength=36. Thestatus=<code>text that the QR and PIN polls match on stays.The object ID mismatch in
uploadMediaByE2EEput every response header into its message anddata. It now carries{ objId, previewObjId }.Checklist
pnpm run build,pnpm run check,pnpm test,pnpm run test:scripts; new tests inbase/request/mod.test.tsandbase/obs/upload_e2ee.test.tsfail when either leak returns)Implemented with Claude Opus 5.5 (xhigh) and reviewed with ChatGPT (Pro) in Claude Code via T3 Code.