Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes password login on
ANDROIDandANDROIDSECONDARY. #192 moved the registration auth calls to/api/v4p/rs, butloginV2andconfirmE2EELoginstill send binary thrift, which the gateway rejects withx-lc: 400and an empty body. The protocol is now picked alongside the endpoint: compact on/api/v4p/rs, binary on/api/v3p/rs.Tested with new unit tests and a live password login on
ANDROIDSECONDARY, using version 3.6.4 with the same protocol rule, which completed through the PIN step.Checklist
If you feel good :), please do the contents of the checklist.