[lasagna + concepts] Inner classes hint#1826
Open
VaiaPatta1985 wants to merge 4 commits intoexercism:mainfrom
Open
[lasagna + concepts] Inner classes hint#1826VaiaPatta1985 wants to merge 4 commits intoexercism:mainfrom
VaiaPatta1985 wants to merge 4 commits intoexercism:mainfrom
Conversation
Updated intro of first concept exercise to include a mention of nested classes.
Update basic concepts to mention inner classes.
Added forgotten comment in code illustrating nested classes.
Added forgotten comment in code illustrating nested classes (in basics).
Contributor
Author
|
Heads-up: The PR should contain FOUR commits, not two. The other two were made after making the PR. If there's something I can do to fix this, please tell me. |
kotp
previously approved these changes
Mar 29, 2026
kotp
dismissed
their stale review
Lasagna would not readily facilitate namespaces like this, as a concept.
kotp
requested changes
Mar 29, 2026
Comment on lines
+50
to
+63
| Classes can contain other classes (_inner classes_): | ||
|
|
||
| ``` | ||
| # Define outer class | ||
| class Calculator | ||
| # Define inner class | ||
| class SpecialHandler | ||
| # ... | ||
| end | ||
| # ... | ||
| end | ||
| ``` |
Member
There was a problem hiding this comment.
I am not understanding why or how the Lasgna problem introduces name spacing. The other change is good, though.
Member
There was a problem hiding this comment.
I just do not want this to be confusing for this exercise specifically, and it may be enough that the concept documentation mentions and shows as you do.
This exercise as a concept should really not concern itself with nested classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated lasagna intro and concepts basics to include mention of inner classes. Solves #1825
.