Repository navigation
Update to v2 - #43
Update to v2#43
Conversation
|
Woah, that was a fast CI run. It's usually 25 - 30 seconds. |
There was a problem hiding this comment.
Of all the repos to have an editor config, this seems like it would be the most appropriate 😆
There was a problem hiding this comment.
Nah, the runner currently skips .vimrc loading when we invoke vim in bin/run.sh. The file is a leftover from the v1 setup where we invoked vim and passed it in manually to load Vader. That's not needed since I moved loading Vader into lib/runner.vim.
This avoids an issue where someone pulls the test runner into a Vim session but forgot to point Vim at the local .vimrc file first. I did a couple of times last week. The test runner will work without additional configuration. This also keeps the test runner configuration bits inside runner.vim itself.
There was a problem hiding this comment.
This however gave me an idea. Vader is only a couple of kilobytes. We could provide a copy and a .vimrc in each exercise that loads Vader and the student code dynamically, running the tests. Students only need Vim installed so vim -N -u .vimrc could reliably run the tests from within the exercise folder. That means we can add Vim script to exercism test. If a student wants to use their own settings, they can just start Vim regularly and not use the local settings which are specific to running the tests with the Vader.
There was a problem hiding this comment.
I think that'd be neat! awk, bash, jq, gdscript and more ship runner code. GDScript just got stub project files. Having a .vimrc for the exercises would be cool.
There was a problem hiding this comment.
This would overlay existing configs though, right? It might be annoying to have my personal root .vimrc ignored.
There was a problem hiding this comment.
It ignores the local .vimrc unless you pass it in using -U and just runs your personal .vimrc. So you could do that for when you're editing your solution and then still use exercism test to test the code in a separate Vim session. If you wanted to test the code in a different setup, then the local .vimrc could be a starting-off point for customization or you just install Vader in your personal .vimrc and then run the test code how you want.
There was a problem hiding this comment.
I'd recommend not calling it ".vimrc" -- that's confusing for vim users. Something exercism-related perhaps.
There was a problem hiding this comment.
Yeah, probably runner.vim or run-tests.vim. We can discuss this further on the forums and brainstorm what all might be useful to include if we were to provide something to facilitate the testing workflow.
|
I love to see the runner implemented in the language! |
https://forum.exercism.org/t/bump-test-runner-to-v2/84316/2