Repository navigation
Conversation
Adds the tree-building practice exercise (difficulty 5), split out of exercism#307. It is a refactoring exercise, so the stub is a complete but deliberately poor implementation for the student to clean up; it passes the suite unchanged, as does the example. `check_parents` in the example returns `!` rather than `!void`, because V 0.4.8 -- the version the current test runner image pins -- rejects `!void` and asks for `?` instead. `!` is the same function signature on every V version the track supports. Registers the exercise in config.json. Verified with bin/verify-exercises-in-docker (the current test runner image) and with V 0.5.2 for bin/test. configlet lint passes, and v fmt -l / v vet are clean on the new files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Tree Building practice exercise (difficulty 5), split out of #307.
tree-building.v-- stub.meta/example.v-- example solutionrun_test.v-- 16 tests, built from the canonical data inproblem-specifications.meta/config.json,.meta/tests.toml,.docs/config.json-- registers the exerciseAdjustments for the test runner's V version
check_parentsin the example returns!rather than!void, becauseV 0.4.8 rejects
!voidand asks for?instead.!is the same functionsignature on every V version the track supports.
One self-contained commit that touches nothing outside the exercise, so it can be merged on its own.
Verification
bin/verify-exercises-in-docker(the currentvlang-test-runnerimage, V 0.4.8): pass, 16/16 tests.vlang/setup-vinstalls forbin/testin CI: pass.configlet lintpasses;v fmt -landv vetare clean on the new files.For the merge commit
Not needed: a brand new exercise does not change the outcome of any existing exercise's tests.