Skip to content

Reapply "[eas-cli][build-tools][worker] bump @expo/config and @expo/c…#3543

Merged
quinlanj merged 1 commit intomainfrom
@quin/revert-revert
Mar 30, 2026
Merged

Reapply "[eas-cli][build-tools][worker] bump @expo/config and @expo/c…#3543
quinlanj merged 1 commit intomainfrom
@quin/revert-revert

Conversation

@quinlanj
Copy link
Copy Markdown
Member

…onfig-plugins (#3527)" (#3534)

This reverts commit 92ad6b5.

Why

The recent change to read the config first with expo config at #3536 should theoretically make this bump safe again.

Test Plan

current tests pass

@quinlanj quinlanj requested review from kitten and sjchmiela March 25, 2026 20:26
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.17%. Comparing base (4e95a29) to head (d8d67e0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/worker/src/external/analytics.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3543      +/-   ##
==========================================
- Coverage   54.17%   54.17%   -0.00%     
==========================================
  Files         822      822              
  Lines       35139    35141       +2     
  Branches     7246     7247       +1     
==========================================
  Hits        19033    19033              
- Misses      16019    16021       +2     
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quinlanj quinlanj requested a review from douglowder March 26, 2026 20:42
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@quinlanj quinlanj force-pushed the @quin/revert-revert branch from e1aab73 to d8d67e0 Compare March 30, 2026 19:38
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 59ad2c2 into main Mar 30, 2026
10 checks passed
@quinlanj quinlanj deleted the @quin/revert-revert branch March 30, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants