Skip to content

Consolidate ax/api and ax/benchmark tests (#5008)#5008

Open
eonofrey wants to merge 3 commits intofacebook:mainfrom
eonofrey:export-D95606935
Open

Consolidate ax/api and ax/benchmark tests (#5008)#5008
eonofrey wants to merge 3 commits intofacebook:mainfrom
eonofrey:export-D95606935

Conversation

@eonofrey
Copy link
Contributor

@eonofrey eonofrey commented Mar 10, 2026

Summary:

Part of a 19-diff stack to consolidate repetitive tests across Ax using subTest. Consolidate 11 test files in ax/api/ and ax/benchmark/ — adds subTest to benchmark result, benchmark metric, and API utils tests.

Differential Revision: D95606935

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 10, 2026
@meta-codesync
Copy link

meta-codesync bot commented Mar 10, 2026

@eonofrey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95606935.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 99.54751% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.84%. Comparing base (1dda964) to head (1f3cd94).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hviz/tests/test_hierarchical_search_space_graph.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5008      +/-   ##
==========================================
- Coverage   96.84%   96.84%   -0.01%     
==========================================
  Files         606      606              
  Lines       65404    65339      -65     
==========================================
- Hits        63341    63277      -64     
+ Misses       2063     2062       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eonofrey added a commit to eonofrey/Ax that referenced this pull request Mar 10, 2026
Summary:

Part of a 19-diff stack to consolidate repetitive tests across Ax using `subTest`. Consolidate 11 test files in ax/api/ and ax/benchmark/ — adds subTest to benchmark result, benchmark metric, and API utils tests.

Differential Revision: D95606935
@meta-codesync meta-codesync bot changed the title Consolidate ax/api and ax/benchmark tests Consolidate ax/api and ax/benchmark tests (#5008) Mar 16, 2026
eonofrey added a commit to eonofrey/Ax that referenced this pull request Mar 16, 2026
Summary:

Part of a 19-diff stack to consolidate repetitive tests across Ax using `subTest`. Consolidate 11 test files in ax/api/ and ax/benchmark/ — adds subTest to benchmark result, benchmark metric, and API utils tests.

Differential Revision: D95606935
eonofrey added a commit to eonofrey/Ax that referenced this pull request Mar 16, 2026
Summary:
Pull Request resolved: facebook#5008

Part of a 19-diff stack to consolidate repetitive tests across Ax using `subTest`. Consolidate 11 test files in ax/api/ and ax/benchmark/ — adds subTest to benchmark result, benchmark metric, and API utils tests.

Differential Revision: D95606935
Summary:

Part of a 19-diff stack to consolidate repetitive tests across Ax using `subTest`. Consolidate 8 test files in ax/adapter/ and ax/adapter/transforms/ — adds subTest parameterization to torch adapter, trial-as-task transform, logit transform, and objective-as-constraint tests.

Differential Revision: D95603401
Summary:

Part of a 19-diff stack to consolidate repetitive tests across Ax and PTS using `subTest`. Consolidate 11 test files in ax/analysis/ (plotly, healthcheck, graphviz) — adds subTest to top surfaces, metric summary, search space summary, and summary tests.

Differential Revision: D95603642
Summary:

Part of a 19-diff stack to consolidate repetitive tests across Ax using `subTest`. Consolidate 11 test files in ax/api/ and ax/benchmark/ — adds subTest to benchmark result, benchmark metric, and API utils tests.

Differential Revision: D95606935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants