fix: multiple unsafe c string operations exist in ipc in ipc.c#265
Open
orbisai0security wants to merge 1 commit into
Open
fix: multiple unsafe c string operations exist in ipc in ipc.c#265orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D104775173. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
common/recipes-lib/ipc/files/ipc.c.Vulnerability
V-001common/recipes-lib/ipc/files/ipc.c:109Description: Multiple unsafe C string operations exist in ipc.c and DBusServerMemtest.c. sprintf() constructs Unix domain socket paths at lines 109 and 259 with no bounds checking on the 'endpoint' parameter. strcpy() at line 329 copies the endpoint string into a fixed-size buffer without length validation. strcat() at DBusServerMemtest.c:73 appends to objectName without verifying remaining buffer space. The sun_path field in struct sockaddr_un is typically 108 bytes; an endpoint name exceeding this limit causes a stack or heap buffer overflow, overwriting adjacent memory.
Changes
common/recipes-lib/ipc/files/ipc.cVerification
Automated security fix by OrbisAI Security