Skip to content

fix: multiple unsafe c string operations exist in ipc in ipc.c#265

Open
orbisai0security wants to merge 1 commit into
facebook:heliumfrom
orbisai0security:fix-ipc-sprintf-buffer-overflow
Open

fix: multiple unsafe c string operations exist in ipc in ipc.c#265
orbisai0security wants to merge 1 commit into
facebook:heliumfrom
orbisai0security:fix-ipc-sprintf-buffer-overflow

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in common/recipes-lib/ipc/files/ipc.c.

Vulnerability

Field Value
ID V-001
Severity CRITICAL
Scanner multi_agent_ai
Rule V-001
File common/recipes-lib/ipc/files/ipc.c:109
CWE CWE-120

Description: Multiple unsafe C string operations exist in ipc.c and DBusServerMemtest.c. sprintf() constructs Unix domain socket paths at lines 109 and 259 with no bounds checking on the 'endpoint' parameter. strcpy() at line 329 copies the endpoint string into a fixed-size buffer without length validation. strcat() at DBusServerMemtest.c:73 appends to objectName without verifying remaining buffer space. The sun_path field in struct sockaddr_un is typically 108 bytes; an endpoint name exceeding this limit causes a stack or heap buffer overflow, overwriting adjacent memory.

Changes

  • common/recipes-lib/ipc/files/ipc.c

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
@meta-cla meta-cla Bot added the CLA Signed label May 12, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 12, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D104775173. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant