Add TouchableSpan interface for position-aware touch on text spans (#56709)#56709
Closed
andrewdacenko wants to merge 1 commit intofacebook:mainfrom
Closed
Add TouchableSpan interface for position-aware touch on text spans (#56709)#56709andrewdacenko wants to merge 1 commit intofacebook:mainfrom
andrewdacenko wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@andrewdacenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97417356. |
896e330 to
6c168bc
Compare
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
May 7, 2026
…acebook#56709) Summary: Changelog: [Internal] Introduces `TouchableSpan`, an interface for spans that receive full `MotionEvent` touch events from `PreparedLayoutTextView`. Unlike `ClickableSpan` which only provides an `onClick` callback with no position information, `TouchableSpan` receives the full `MotionEvent`, enabling position-aware interactions such as dismiss animations originating from the tap point. Reviewed By: Abbondanzo Differential Revision: D97417356
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
May 7, 2026
…acebook#56709) Summary: Changelog: [Internal] Introduces `TouchableSpan`, an interface for spans that receive full `MotionEvent` touch events from `PreparedLayoutTextView`. Unlike `ClickableSpan` which only provides an `onClick` callback with no position information, `TouchableSpan` receives the full `MotionEvent`, enabling position-aware interactions such as dismiss animations originating from the tap point. Reviewed By: Abbondanzo Differential Revision: D97417356
6c168bc to
9bf20a1
Compare
…acebook#56709) Summary: Changelog: [Internal] Introduces `TouchableSpan`, an interface for spans that receive full `MotionEvent` touch events from `PreparedLayoutTextView`. Unlike `ClickableSpan` which only provides an `onClick` callback with no position information, `TouchableSpan` receives the full `MotionEvent`, enabling position-aware interactions such as dismiss animations originating from the tap point. Reviewed By: Abbondanzo Differential Revision: D97417356
9bf20a1 to
42bc4a2
Compare
|
This pull request has been merged in 2a0f595. |
Collaborator
|
This pull request was successfully merged by @andrewdacenko in 2a0f595 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Introduces
TouchableSpan, an interface for spans that receive fullMotionEventtouch events fromPreparedLayoutTextView. UnlikeClickableSpanwhich only provides anonClickcallback with noposition information,
TouchableSpanreceives the fullMotionEvent,enabling position-aware interactions such as dismiss animations
originating from the tap point.
Reviewed By: Abbondanzo
Differential Revision: D97417356