Skip to content

🥅 Stop deploys that can't work and report unconfirmed ones correctly - #363

Merged
patrick91 merged 2 commits into
mainfrom
2026-10-08-stop-deploys-that-can-t-work-and-report-unconfirme
Nov 5, 2026
Merged

patrick91 merged 2 commits into
mainfrom
2026-10-08-stop-deploys-that-can-t-work-and-report-unconfirme

Conversation

@patrick91

@patrick91 patrick91 commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Stack 🍰

@patrick91 patrick91 added the feature New feature or request label Oct 12, 2026
@patrick91 patrick91 changed the title 🥅 Stop deploys that can't work and report unconfirmed ones honestly 🥅 Stop deploys that can't work and report unconfirmed ones correctly Oct 16, 2026
- Stop before uploading when the app's directory doesn't exist in the
  deployed folder. Apps connected to GitHub get a hint to deploy from the
  repository root. --force skips the check.
- Stop when there's nothing to upload. .fastapicloud, the local app link,
  is no longer uploaded, so a folder holding only it counts as empty.
- Ask before deploying the home directory; refuse in CI and --json.
- In CI, fail with a hint when no app ID is configured instead of
  prompting.
- Treat degraded, degraded_oom and expired as failed deployments, and
  exit 3 instead of 0 when verification can't be confirmed.
- Require rich-toolkit 0.20.6, where confirm(default=False) starts on
  "No". Prompts that default to "No" (home directory, env delete, domain
  remove, resource disconnect, workflow overwrite) now decline on Enter.

Part of fastapilabs/cloud#976

Shortcake-Parent: main
@patrick91
patrick91 force-pushed the 2026-10-08-stop-deploys-that-can-t-work-and-report-unconfirme branch from ea2f77a to fe465f3 Compare November 5, 2026 11:14
@patrick91
patrick91 marked this pull request as ready for review November 5, 2026 11:23
@patrick91
patrick91 merged commit bc6d606 into main Nov 5, 2026
19 checks passed
@patrick91
patrick91 deleted the 2026-10-08-stop-deploys-that-can-t-work-and-report-unconfirme branch November 5, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant