fix: Fix SparkRetrievalJob.persist() failing for SparkSource#6410
Open
ntkathole wants to merge 1 commit into
Open
fix: Fix SparkRetrievalJob.persist() failing for SparkSource#6410ntkathole wants to merge 1 commit into
ntkathole wants to merge 1 commit into
Conversation
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #6261
SparkRetrievalJob.persist()failed in two scenarios:Remote offline store path: When using
type: remoteinfeature_store.yamlpointing to a Spark offline server, the server callsSavedDatasetStorage.from_data_source(data_source)to convert the registeredSparkSourceinto storage. This raisedValueErrorbecauseSparkSourcewas not registered in the_DATA_SOURCE_TO_SAVED_DATASET_STORAGEmapping, andSavedDatasetSparkStoragelacked afrom_data_source()method.Path-based SparkSource: When using a path-based
SparkSource(e.g., S3 with parquet),persist()required a table name and raisedValueErrorif one wasn't provided, even though the storage had a valid path configured.