Repository navigation
fix(ledger): raise /errors/asset-mismatch for CURRENCY on asset transfers - #122
Merged
Merged
Conversation
…fers The §6.5 row and ErrorCode.ASSET_MISMATCH existed since 3.55 but nothing produced them, and assetClass CURRENCY on PUT .../asset-transfers was accepted as a tax lot: cash the balance never saw. It is now a recorded MovementRejected (reason asset-mismatch), so it replays as the same 422. Spec 3.58.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/errors/asset-mismatch(spec §6.5,ErrorCode.ASSET_MISMATCH) was catalogued but never raised.assetClass: CURRENCYonPUT /api/v1/accounts/{a}/asset-transfers/{t}was accepted as a tax lot, so cash landed in a holding that the account balance never saw.Fix
Account.transferAssetnow returns aMovementRejectedwith reasonasset-mismatchfor CURRENCY. The existing rejection mapping turns it into a 422, and an idempotent replay returns the same 422.Quantity.requireSameAssetstays anIllegalArgumentException. Holdings are keyed by(symbol, assetClass), so a request cannot reach that guard.Tests
AccountTest.cashThroughTheAssetTransferEndpointIsRejectedAsAssetMismatch. It failed before the fix (the transfer was accepted) and passes after.Spec bumped to 3.58 (§6.5 row, §2.5 note, changelog).