Repository navigation
test: skip local-only MARKETING-LOG.txt contract checks when untracked (fixes CI on #6) - #7
Open
lukisch wants to merge 1 commit into
Conversation
…d (fixes CI on #6) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F2a7HawhsrZ6bFZzM9
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
lukisch
commented
Nov 8, 2026
lukisch
left a comment
lukisch
left a comment
Contributor
Author
There was a problem hiding this comment.
Zweitmodell-Review (LGTM): Skip-Guards für die lokal-only MARKETING-LOG.txt in drei Tests, pytest korrekt importiert, restliche Assertions unverändert. (Formale Approval nicht möglich: gleiches Konto wie PR-Autor.)
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on #6 fails in all
testsjobs: three metadata tests readMARKETING-LOG.txt, which is intentionally untracked (and asserted untracked bytest_internal_logs_not_tracked), so it never exists in CI.Fix
Skip those three tests when the local-only file is absent (same pattern as ProFiler #15 / SQLiteViewer #4). Verified locally:
tests/test_metadata.py43 passed, 3 skipped; ruff clean. Qt-dependent tests could not run in my sandbox (no libEGL).Merge into #6's branch (base is that branch).
Generated by Claude Code