fix: use secondary app if it is passed into FirebaseAuthUI#2313
Open
russellwheatley wants to merge 4 commits intoversion-10.0.0-beta03from
Open
fix: use secondary app if it is passed into FirebaseAuthUI#2313russellwheatley wants to merge 4 commits intoversion-10.0.0-beta03from
russellwheatley wants to merge 4 commits intoversion-10.0.0-beta03from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables FirebaseAuthActivity to support secondary Firebase Auth instances by passing the authUI object via a static cache. While this correctly handles multi-app scenarios, the implementation of cache retrieval using remove() in onCreate is problematic as it prevents the activity from surviving configuration changes like screen rotations. Furthermore, the static caches for configurations and auth instances introduce potential memory leaks and test isolation issues that should be addressed by implementing a proper cleanup mechanism.
auth/src/main/java/com/firebase/ui/auth/FirebaseAuthActivity.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/FirebaseAuthActivity.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2312