Skip to content

decision(storage-resize-images): kit/extension parity – ALLOWED_EVENT_TYPES is ignored, the kit reads EXT_SELECTED_EVENTS #3273

Open

Description

@IzaakGough

storage-resize-images kit/extension parity. Priority: low. An extension .env copied to the kit publishes every event type.

Difference

  • Extension: ALLOWED_EVENT_TYPES limits which events are published.
  • Kit: reads EXT_SELECTED_EVENTS instead and ignores ALLOWED_EVENT_TYPES. firebase ext:migrate writes EXT_SELECTED_EVENTS (by reading the CLI), so migrated projects are fine. A user who copies their extension .env, as the README's lift-and-shift wording invites, gets every event. The README's Events section names only EVENTARC_CHANNEL.

Reproduced

  • ALLOWED_EVENT_TYPES set to onSuccess only: the deploy succeeds and all event types are published.
  • EXT_SELECTED_EVENTS set to onSuccess only: exactly one event is published.

Code

Resolution

Two options:

  • Fall back to ALLOWED_EVENT_TYPES when EXT_SELECTED_EVENTS is unset.
  • Keep it and document EXT_SELECTED_EVENTS in the README's Events section.

Metadata

Metadata

Assignees

Labels

decisionNeeds a decision before work can proceedkitsparity

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions