Skip to content

decision(firestore-send-email): kit/extension parity – blank required params fail the kit deploy, the extension uses defaults #3324

Open

Description

@CorieW

firestore-send-email kit/extension parity. Priority: low. A config that works on the extension fails to deploy as a kit.

Difference

  • Extension: a blank required param falls back to its declared default.
  • Kit: assertRequiredParams() stops the deploy with Required parameters are set to an empty value: … when DATABASE, AUTH_TYPE, MAIL_COLLECTION, DEFAULT_FROM, TTL_EXPIRE_TYPE or TTL_EXPIRE_VALUE is blank in .env. DATABASE_REGION is left out on purpose: a blank value leaves the function without a region, so the CLI picks one.

Reproduced

Seen in the code, not tested live on this kit. DEFAULT_FROM has no declared default.

Code

Resolution

Keep the stricter check, and mark which settings can't be blank in the README, as the firestore-bigquery-export kit README does (#3319).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

decisionNeeds a decision before work can proceedkitsparity

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions