Skip to content

decision(storage-resize-images): kit/extension parity – blank required params fail the kit deploy, the extension uses defaults #3327

Open

Description

@CorieW

storage-resize-images kit/extension parity. Priority: low. A config that works on the extension fails to deploy as a kit.

Difference

  • Extension: a blank required param falls back to its declared default.
  • Kit: assertRequiredParams() stops the deploy with Required parameters are set to an empty value: … when IMG_BUCKET, IMG_SIZES, DELETE_ORIGINAL_FILE, IMAGE_TYPE, FUNCTION_MEMORY or CONTENT_FILTER_LEVEL is blank in .env.

Reproduced

Seen in the code, not tested live on this kit.

Code

Resolution

Keep the stricter check, and mark which settings can't be blank in the README, as the firestore-bigquery-export kit README does (#3320).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

decisionNeeds a decision before work can proceedkitsparity

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions