Skip to content

fix: fix broken and outdated links - #3248

Merged
CorieW merged 5 commits into
nextfrom
fix/broken-links
Nov 3, 2026
Merged

CorieW merged 5 commits into
nextfrom
fix/broken-links

Conversation

@CorieW

@CorieW CorieW commented Oct 19, 2026

Copy link
Copy Markdown
Member

Description

Fixes links that are broken (404), land on the wrong page, or point to private Notion drafts.

Changes

Broken links

  • samples/rtdb-uppercase-messages: fix databaae typo in the Realtime Database setup link.
  • storage-resize-images: update the getDownloadURL link to the current JS reference page.
  • firestore-send-email: remove the trailing / that breaks the Nodemailer OAuth2 and attachments links, and point the SendGrid Categories link at its new Twilio page.
  • firestore-bigquery-export: remove the contributor url, which points to a GitHub account that no longer exists (name and email are kept).
  • firestore-counter: update the Dart linter link in clients/dart/analysis_options.yaml.

Links that redirect to the wrong page

  • docs/storage-resize-images: functions/beta/custom-events → functions/custom-events.
  • firestore-shorten-urls-bitly/CHANGELOG.md: dev.bitly.com/deprecated.html (now redirects to the Bitly dev homepage) → Bitly's authentication docs.

Notion links

  • Replace 14 notion.so links in docs/firestore-bigquery-export and docs/storage-resize-images with relative links to the matching docs in the repo (or same-page anchors in generating-schemas.md).

Versions

  • Bumped only where shipped docs or metadata changed: firestore-send-email 0.2.11, storage-resize-images 0.3.7, rtdb-uppercase-messages 0.0.3.
  • firestore-bigquery-export: added to the unreleased 0.3.4 entry instead of a new version.
  • No bump for firestore-counter (Dart client comment only) or firestore-shorten-urls-bitly (CHANGELOG only).

Testing

  • Every new external URL returns 200; every new relative link and anchor resolves.

Replace links that 404, land on the wrong page, or point to private Notion drafts. Bump the version of extensions whose shipped docs or metadata changed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various documentation files across multiple Firebase extensions to fix broken external links, replace Notion.so URLs with relative local links, and correct typos in documentation paths. It also includes corresponding version bumps and changelog updates. One review comment suggests fixing a misplaced bold markdown syntax in the storage-resize-images get-started guide to ensure correct rendering.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@cabljac cabljac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments.

Comment thread storage-resize-images/POSTINSTALL.md Resolved
Comment thread firestore-send-email/POSTINSTALL.md Resolved
CorieW and others added 3 commits November 3, 2026 16:11
Co-authored-by: Jacob Cable <32874567+cabljac@users.noreply.github.com>
Co-authored-by: Jacob Cable <32874567+cabljac@users.noreply.github.com>
@CorieW
CorieW merged commit 490b13b into next Nov 3, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants