Repository navigation
fix(firestore-send-email): match the extension's cpu, concurrency and ingress - #3316
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the processQueue Cloud Function in the firestore-send-email kit to deploy with specific runtime settings: concurrency: 1, cpu: "gcf_gen1", and ingressSettings: "ALLOW_INTERNAL_ONLY". This prevents out-of-memory errors and dropped events when handling bursts of emails with attachments on 256MiB instances. Documentation, changelog, and tests have been updated accordingly. I have no feedback to provide.
cabljac
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3292. Sets the extension's runtime settings on
processQueue, as #3234 and #3276 did for the other kits. Rebased from the closed #3233.gcf_gen1)ALLOW_INTERNAL_ONLYALLOW_ALLALLOW_INTERNAL_ONLYAt concurrency 80, a burst of mail with attachments ran one 256MiB instance out of memory. Every event on it was dropped and never retried, so the mail was never sent.
Testing
npm testpasses (174 tests).