Skip to content

fix(firestore-send-email): match the extension's cpu, concurrency and ingress - #3316

Merged
CorieW merged 1 commit into
kitsfrom
fix/kits-send-email-runtime-options
Nov 10, 2026
Merged

CorieW merged 1 commit into
kitsfrom
fix/kits-send-email-runtime-options

Conversation

@CorieW

@CorieW CorieW commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Fixes #3292. Sets the extension's runtime settings on processQueue, as #3234 and #3276 did for the other kits. Rebased from the closed #3233.

Extension Kit before Kit after
Concurrency 1 80 1
CPU 0.1666 1 0.1666 (gcf_gen1)
Ingress ALLOW_INTERNAL_ONLY ALLOW_ALL ALLOW_INTERNAL_ONLY

At concurrency 80, a burst of mail with attachments ran one 256MiB instance out of memory. Every event on it was dropped and never retried, so the mail was never sent.

Testing

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures the processQueue Cloud Function in the firestore-send-email kit to deploy with specific runtime settings: concurrency: 1, cpu: "gcf_gen1", and ingressSettings: "ALLOW_INTERNAL_ONLY". This prevents out-of-memory errors and dropped events when handling bursts of emails with attachments on 256MiB instances. Documentation, changelog, and tests have been updated accordingly. I have no feedback to provide.

@CorieW
CorieW merged commit ecf60fc into kits Nov 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants