Skip to content

chore: Fix broken integrations tests#1202

Open
jonathanedey wants to merge 5 commits intomainfrom
je-fix-flake
Open

chore: Fix broken integrations tests#1202
jonathanedey wants to merge 5 commits intomainfrom
je-fix-flake

Conversation

@jonathanedey
Copy link
Copy Markdown
Collaborator

@jonathanedey jonathanedey commented Apr 7, 2026

  • Replaces broken test links with a fake local server.
  • Removes ReadTimeout integration tests as these are difficult to simulate with a mock server.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Apr 7, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the external service URLs used in integration tests from nghttp2.org to httpbin.org. Feedback suggests replacing these external dependencies with a local mock server to improve test reliability and ensure the tests are hermetic.

@jonathanedey
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the integration tests for ApacheHttp2Transport by replacing external network dependencies with a local FakeServer implementation. This change improves test reliability and execution speed. However, the review feedback identifies a likely copy-paste error in the read timeout tests, where the assertions incorrectly expect a 'Connection Timeout' message instead of a 'Read Timeout' message.

@jonathanedey
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ApacheHttp2TransportIT integration tests to use a local FakeServer instead of external endpoints, improving test reliability. The feedback suggests simplifying the FakeServer constructor using the ServerBootstrap builder and utilizing the close() method for more idiomatic resource management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant