Repository navigation
Editor LinkSelector - Bug fix and update - #1007
Open
AleksandarCila wants to merge 1 commit into
Open
AleksandarCila wants to merge 1 commit into
AleksandarCila wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link popup in the markdown editor is its own form, portaled out of the entity form. React still bubbles that submit to
EntityForm. Confirming a link with the checkmark or Enter therefore validates and may save the entity. The form version changes, the editor remounts from the previous value, and the link is never applied.LinkSelectorBug.mov
LinkSelectornow stops that submit from propagating. An invalid URL also shows an error instead of leaving the popup open with no feedback.Closes 773