Skip to content

Home Page - Make sure drag n drop is completely disabled #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AleksandarCila wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Home Page - Make sure drag n drop is completely disabled #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/firecms_core/src/components/HomePage/DefaultHomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,13 +465,15 @@ export function DefaultHomePage({
isPotentialCardDropTarget={
isDraggingCardOnly
}
disabled={dndDisabled}
>
<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-4 ">
{entriesInGroup.map(
(entry) => (
<SortableNavigationCard
key={entry.url}
entry={entry}
disabled={dndDisabled}
onClick={() => {
let event: CMSAnalyticsEvent =
"unmapped_event";
Expand Down
16 changes: 12 additions & 4 deletions packages/firecms_core/src/components/HomePage/HomePageDnD.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,12 @@ const cloneItemsForDnd = (items: { name: string; entries: NavigationEntry[] }[])
/* ─────────────────────────────────────────────────────────── */
export function SortableNavigationCard({
entry,
onClick
onClick,
disabled
}: {
entry: NavigationEntry;
onClick?: () => void;
disabled?: boolean;
}) {
const {
setNodeRef,
Expand All @@ -82,7 +84,8 @@ export function SortableNavigationCard({
} =
useSortable({
id: entry.url,
animateLayoutChanges
animateLayoutChanges,
disabled
});

const style = {
Expand All @@ -102,14 +105,19 @@ export function NavigationGroupDroppable({
id,
itemIds,
children,
isPotentialCardDropTarget = false
isPotentialCardDropTarget = false,
disabled
}: {
id: UniqueIdentifier;
itemIds: UniqueIdentifier[];
children: React.ReactNode;
isPotentialCardDropTarget?: boolean;
disabled?: boolean;
}) {
const { setNodeRef } = useDroppable({ id });
const { setNodeRef } = useDroppable({
id,
disabled
});

return (
<div
Expand Down
Loading