Automate docs element list for interpolation#4854
Open
leo-collins wants to merge 9 commits intoreleasefrom
Open
Automate docs element list for interpolation#4854leo-collins wants to merge 9 commits intoreleasefrom
leo-collins wants to merge 9 commits intoreleasefrom
Conversation
pbrubeck
reviewed
Feb 2, 2026
pbrubeck
reviewed
Feb 5, 2026
pbrubeck
reviewed
Feb 5, 2026
leo-collins
force-pushed
the
leo/element_list
branch
from
cc3acff to
caef71d
Compare
connorjward
requested changes
Apr 21, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Also please unmark this as draft
|
|
||
| csvwriter.writerow((family, short_name, shape, cellnames)) | ||
| if family in {"Q", "DQ", "DQ L2"}: | ||
| cell = cell_list[-1] |
Contributor
There was a problem hiding this comment.
This makes zero sense without a comment
Contributor
Author
There was a problem hiding this comment.
It looks like we can't do these elements on an interval, even though it says in the manual we can. I think the correct fix is in finat/ufl/elementlist.py
Contributor
There was a problem hiding this comment.
Yeah that seems more reasonable, but @pbrubeck needs to look this all over. Once this line goes I'm happy with everything else.
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
pbrubeck
reviewed
Apr 21, 2026
pbrubeck
previously approved these changes
Apr 21, 2026
dham
reviewed
Apr 21, 2026
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
leo-collins
force-pushed
the
leo/element_list
branch
3 times, most recently
from
6f8c2f4 to
521e3fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires firedrakeproject/fiat#216