Conversation
6c79c43 to
70f5212
Compare
70f5212 to
d8c498f
Compare
rckirby
left a comment
There was a problem hiding this comment.
This is a great idea -- it looks like user just adds a new option to the dictionary if we want to turn it on?
Probably we should have some minimal simple tests, such as parameterizing existing tests of ASMStarPC and ASMVankaPC to turn the coloring option off and on?
e738a9a to
67429d1
Compare
67429d1 to
5349a7c
Compare
ee4dd99 to
8e8d5da
Compare
3ee9028 to
9d3bb76
Compare
ScottMacLachlan
left a comment
There was a problem hiding this comment.
The changes in asm.py look quite reasonable to me. I'm not up enough on the netgen side to comment on that, though...
a6ae764 to
dd17270
Compare
JHopeCollins
left a comment
There was a problem hiding this comment.
Really good that this is highlighted in the demos now.
I think this is very close, it's just very minor comments/queries.
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
Requested changes have been made.
|
@JHopeCollins anything to add? |
There was a problem hiding this comment.
@JHopeCollins anything to add?
No this looks good to go now, thanks for addressing those last comments.
CI failures once again are unrelated docs link failures.
Description
Enables ASMStarPC and ASMVankaPC to group patches by color (non-overlapping vertex/Vanka-stars) into a block diagonal matrix. Coloring is enabled through the petsc option
-pc_star_use_coloring.As a benchmark consider the Poison equation on a 256x256 mesh solved with one process:
Here all solvers are mathematically equivalent, and all of them except TinyASM use Cholmod for the Cholesky factorization of the patch matrices.
Depends on https://gitlab.com/petsc/petsc/-/merge_requests/9069 (merged into release)