fix: use path instead of filepath in FSLoader.Abs for Windows compatibility#375
Open
Yanhu007 wants to merge 1 commit intoflosch:masterfrom
Open
fix: use path instead of filepath in FSLoader.Abs for Windows compatibility#375Yanhu007 wants to merge 1 commit intoflosch:masterfrom
Yanhu007 wants to merge 1 commit intoflosch:masterfrom
Conversation
Yanhu007
force-pushed
the
fix/fsloader-path-separator
branch
from
dcec8e7 to
868a89c
Compare
FSLoader.Abs uses filepath.Join/Dir which produce backslash-separated paths on Windows. Since fs.FS (including embed.FS) expects forward slashes, this causes "unable to resolve template" errors on Windows. Use the path package (which always uses forward slashes) for FSLoader path operations, keeping filepath for the LocalFilesystemLoader which operates on the OS filesystem. Fixes flosch#373
Yanhu007
force-pushed
the
fix/fsloader-path-separator
branch
from
868a89c to
86860c4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373
Problem
FSLoader.Abs()usesfilepath.Joinandfilepath.Dir, which produce backslash-separated paths on Windows. Sincefs.FS(includingembed.FS) always uses forward slashes per theio/fsspecification, template resolution fails on Windows with "unable to resolve template".Fix
Use
path.Joinandpath.Dir(always forward slashes) instead offilepath.Joinandfilepath.DirforFSLoader.LocalFilesystemLoadercontinues to usefilepathsince it operates on OS paths.