fix: use path instead of filepath in FSLoader for fs.FS compatibility#376
Open
Yanhu007 wants to merge 1 commit intoflosch:masterfrom
Open
fix: use path instead of filepath in FSLoader for fs.FS compatibility#376Yanhu007 wants to merge 1 commit intoflosch:masterfrom
Yanhu007 wants to merge 1 commit intoflosch:masterfrom
Conversation
FSLoader.Abs used filepath.Join and filepath.Dir which produce backslash-separated paths on Windows. Since fs.FS (including embed.FS) requires forward-slash paths per the Go specification, this caused "unable to resolve template" errors on Windows. Use path.Join and path.Dir instead, which always use forward slashes regardless of platform. Fixes flosch#373
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373
Problem
FSLoader.Absusesfilepath.Joinandfilepath.Dir, which produce backslash-separated paths on Windows (e.g.,templates\index.html). However,fs.FSimplementations (includingembed.FS) require forward-slash paths per the Go fs.FS specification. This causes"unable to resolve template"errors when usingNewFSLoaderon Windows.Fix
Replace
filepath.Join/filepath.Dirwithpath.Join/path.DirinFSLoader.Abs. Thepathpackage always uses forward slashes, matching thefs.FSconvention.Only the
FSLoaderis changed —LocalFilesystemLoadercorrectly usesfilepathsince it operates on the OS filesystem.