Fix persistent and disappearing error badges for Inspector

[khanak0509]

issue #9524
This PR fixes issue #9524 where the Inspector error badge was acting weird — like it kept increasing incorrectly and sometimes disappeared on tab switch. The count was blindly incremented, errors were getting deleted due to aggressive filtering, and the badge was cleared too early.

How I fixed it:
Basically, I made the badge count derived from actual unread errors instead of manually incrementing it, removed the aggressive filtering, and stopped clearing the badge on tab switch — like now it only resets on a fresh connection or Hot Restart.
before

before.mov

after

after.mov

Pre-launch Checklist

General checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read the Flutter Style Guide recently, and have followed its advice.
• I signed the CLA.
• I updated/added relevant documentation (doc comments with ///).

Issues checklist

• I listed at least one issue that this PR fixes in the description above.
• I listed at least one issue which has the contributions-welcome or good-first-issue label.
• I did not list at least one issue with the contributions-welcome or good-first-issue label. I understand this means my PR might take longer to be reviewed.

Tests checklist

• I added new tests to check the change I am making...
• OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

• I did not use any AI tooling in creating this PR.
• OR I did use AI tooling, and...
  • I read the AI contributions guidelines and agree to follow them.
  • I reviewed all AI-generated code before opening this PR.
  • I understand and am able to discuss the code in this PR.
  • I have verifed the accuracy of any AI-generated text included in the PR description.
  • I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

• This PR does not change the DevTools UI or behavior and...
  • I added the release-notes-not-required label or left a comment requesting the label be added.
• OR this PR does change the DevTools UI or behavior and...
  • I added an entry to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.
  • I included before/after screenshots and/or a GIF demo of the new UI to my PR description.
  • I ran the DevTools app locally to manually verify my changes.

If you need help, consider asking for help on Discord.

[gemini-code-assist]

Code Review

This pull request refactors the ErrorBadgeManager to use a derived-count model for the Inspector, where the badge count is automatically updated based on the number of unread errors. This change removes the need for manual badge count increments and the filterErrors logic in the InspectorController. A concern was raised regarding redundant calls to clearErrorCount remaining in the InspectorController files, which should be removed to maintain code clarity and align with the new error tracking model.

[kenzieschmoll]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the error badge management system to ensure the Inspector's badge count accurately reflects unread errors. It removes manual error filtering and explicit badge increments, implementing an automated update mechanism within ErrorBadgeManager that recalculates unread counts when errors are added or marked as read. Feedback suggests simplifying a redundant conditional check and notes a potential performance bottleneck in the O(N) unread count calculation.