Handle null values for FlutterStore.flutterClientId.#9820
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom May 5, 2026
Merged
Handle null values for FlutterStore.flutterClientId.#9820auto-submit[bot] merged 3 commits intoflutter:masterfrom
FlutterStore.flutterClientId.#9820auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates devtools_shared to version 13.0.1 to handle null values for FlutterStore.flutterClientId. The changes involve making the flutterClientId getter nullable and adding null-coalescing logic in the server API. Feedback indicates that changing the return type to String? constitutes a breaking change that should be avoided in a patch release; instead, the getter should return an empty string for null values. Additionally, the reviewer noted that the implementation should verify if analytics are enabled before returning the client ID to comply with existing policy.
bkonyi
approved these changes
May 5, 2026
kenzieschmoll
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required bug fix for the devtools release: #9819. This also bumps the flutter version to the latest.