Skip to content

chore: emit recovery event when reconciliation succeeds after failure #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iam-Karan-Suresh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: emit recovery event when reconciliation succeeds after failure #1428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/controller/helmrelease_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ func (r *HelmReleaseReconciler) reconcileRelease(ctx context.Context,

log := ctrl.LoggerFrom(ctx)

// Snapshot the object's readiness state to detect failure recovery.
wasNotReady := !conditions.IsReady(obj)

// Check deprecated fields.
if obj.GetRollback().Recreate {
log.Info("warning: the .spec.rollback.recreate field is deprecated and has no effect. " +
Expand Down Expand Up @@ -441,6 +444,13 @@ func (r *HelmReleaseReconciler) reconcileRelease(ctx context.Context,
}
return ctrl.Result{}, err
}

// Emit recovery event if the release was not ready before and is now ready.
if wasNotReady && conditions.IsReady(obj) {
r.Eventf(obj, corev1.EventTypeNormal, meta.SucceededReason,
"Release reconciliation recovered from previous failure")
}

return jitter.JitteredRequeueInterval(ctrl.Result{RequeueAfter: obj.GetRequeueAfter()}), nil
}

Expand Down