Repository navigation
Document how extra Flux controller replicas behave - #2709
Merged
Merged
Conversation
Extra replicas don't add capacity because only the leader reconciles, and extra source-controller replicas never become ready, so the rollout never completes. Say so on the sharding page and point to sharding instead. Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
Contributor
Author
|
@stefanprodan could you have a look at this small docs change when you get a chance? Thanks! |
matheuscscp
reviewed
Nov 7, 2026
Extra replicas work for failover, they just don't add capacity. Standby source-controller replicas stay not ready by design. Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
matheuscscp
reviewed
Nov 7, 2026
Apply the review suggestion. Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fluxcd/flux2#5880
Adds a note to the sharding page about extra controller replicas, as discussed in the issue. They work as failover standbys but don't add capacity, since only the leader reconciles. Standby source-controller replicas stay not ready by design. The note points to sharding for spreading the load.
I built the site with Hugo 0.122.0 and checked that the note renders on the page.