Skip to content

Document how extra Flux controller replicas behave - #2709

Merged
matheuscscp merged 3 commits into
fluxcd:mainfrom
marsluca:controller-replicas-note
Nov 7, 2026
Merged

matheuscscp merged 3 commits into
fluxcd:mainfrom
marsluca:controller-replicas-note

Conversation

@marsluca

@marsluca marsluca commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes fluxcd/flux2#5880

Adds a note to the sharding page about extra controller replicas, as discussed in the issue. They work as failover standbys but don't add capacity, since only the leader reconciles. Standby source-controller replicas stay not ready by design. The note points to sharding for spreading the load.

I built the site with Hugo 0.122.0 and checked that the note renders on the page.

Extra replicas don't add capacity because only the leader reconciles,
and extra source-controller replicas never become ready, so the
rollout never completes. Say so on the sharding page and point to
sharding instead.

Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 29, 2026 09:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@marsluca

marsluca commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@stefanprodan could you have a look at this small docs change when you get a chance? Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the narrowly scoped documentation change clearly explains the one-replica guidance and sharding alternative.

No open issues 🎉

Review effort: Lite

Extra replicas work for failover, they just don't add capacity.
Standby source-controller replicas stay not ready by design.

Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
@marsluca marsluca changed the title Document that Flux controllers need replicas: 1 Document how extra Flux controller replicas behave Nov 7, 2026
Copilot AI lite review requested due to automatic review settings November 7, 2026 21:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Apply the review suggestion.

Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 7, 2026 22:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@matheuscscp matheuscscp added area/docs Documentation related issues and pull requests backport:v2-10 To be backported to v2-10 labels Nov 7, 2026

@matheuscscp matheuscscp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheuscscp
matheuscscp merged commit 186a68f into fluxcd:main Nov 7, 2026
7 checks passed
@fluxcdbot

Copy link
Copy Markdown
Member

Successfully created backport PR for v2-10:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation related issues and pull requests backport:v2-10 To be backported to v2-10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

source-controller non-leader pods permanently fail readiness probe in HA mode (v2.8.5)

4 participants