Repository navigation
Update golangci-lint version to v2.15 - #179
Merged
Merged
Conversation
mop-reporting's `make lint` runs fine locally but fails in CI: > Error: main.go:3:8: could not import os (/opt/hostedtoolcache/go/1.27.3/x64/src/os/dir.go:8:2: could not import internal/bytealg (/opt/hostedtoolcache/go/1.27.3/x64/src/internal/bytealg/bytealg.go:8:2: could not import internal/cpu (-: could not load export data: internal error in importing "internal/cpu" (cannot decode "internal/cpu", export data version 5 is greater than maximum supported version 4); please report an issue))) (typecheck) mod-reporting's CI lint job (go-lint.yml) calls the shared lint workflow in folio-org/.github. That workflow's golangci-lint step, .github/workflows/go-lint-golangci.yml@v1, does two relevant things: * actions/setup-go with go-version: 'stable', which now installs Go 1.27.3 (the version in your error). * golangci/golangci-lint-action@v9 with version: v2.13, which resolves to v2.13.2. The 1.27.3 standard library is compiled in a newer internal format, version 5. golangci-lint reads that format through Go's golang.org/x/tools package, which added support for version 5 on 2026-09-02. So we need a newer version of golangci-lint which understands that format.
Contributor
Author
|
@dcrossleyau I don't seem to be able to tag you as a reviewer for this. Can you please take a look, and merge if it looks good? Until that's done I can't merge anything in mod-reporting. |
dcrossleyau
self-requested a review
October 28, 2026 02:44
Contributor
|
This is now done. Also an upgrade to staticcheck to use Go 1.27 etc. |
Contributor
Author
|
Excellent, many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mop-reporting's
make lintruns fine locally but fails in CI:mod-reporting's CI lint job (go-lint.yml) calls the shared lint workflow in folio-org/.github. That workflow's golangci-lint step, .github/workflows/go-lint-golangci.yml@v1, does two relevant things:
The 1.27.3 standard library is compiled in a newer internal format, version 5. golangci-lint reads that format through Go's golang.org/x/tools package, which added support for version 5 on 2026-09-02. So we need a newer version of golangci-lint which understands that format.