Skip to content

MODORDERS-1495. Enforce acquisition unit restrictions for piece status changes made from the “Claiming” app - #1361

Merged
SerhiiNosko merged 2 commits into
masterfrom
MODORDERS-1495
Nov 11, 2026
Merged

SerhiiNosko merged 2 commits into
masterfrom
MODORDERS-1495

Conversation

@SerhiiNosko

Copy link
Copy Markdown
Contributor

Purpose

https://folio-org.atlassian.net/browse/MODORDERS-1495

Approach

Provide a brief technical summary of the changes.


Pre-Review Checklist

  • Self-reviewed Code — Reviewed code for issues, unnecessary parts, and overall quality.
  • Change Notes — NEWS.md updated with clear description and issue key.
  • Testing — Confirmed changes were tested locally or on dev environment.
  • Logging: Confirmed that logging is appropriately handled.
  • Breaking Changes — Handled all required actions if changes affect API, DB, or interface versions.
    • API/schema changes
    • Interface version updates
    • DB schema changes / migration scripts
  • New Properties / Environment Variables — Updated README.md if new configs were added.

@SerhiiNosko
SerhiiNosko requested a review from a team as a code owner November 10, 2026 11:01
.map(title -> protectionService.isOperationRestricted(title.getAcqUnitIds(), ProtectedOperationType.UPDATE, requestContext))
.toList())
.map(Future::all)
.compose(Future::all)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before fix (Network):

Image

After fix (Network):

Image

Before fix page:

Image

After fix page:

Image

@SerhiiNosko SerhiiNosko Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI ticket can be needed to handle userNotAMemberOfTheAcq correctly instead of showing General error

@sonarqubecloud

Copy link
Copy Markdown

@SerhiiNosko
SerhiiNosko merged commit ffb812d into master Nov 11, 2026
16 checks passed
@SerhiiNosko
SerhiiNosko deleted the MODORDERS-1495 branch November 11, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants