Skip to content

MODORDERS-1478: Add DeployConfig.json to mod-orders (ADR-0013 Configuration Management) - #1362

Merged
SerhiiNosko merged 7 commits into
masterfrom
MODORDERS-1478-2
Nov 13, 2026
Merged

MODORDERS-1478: Add DeployConfig.json to mod-orders (ADR-0013 Configuration Management)#1362
SerhiiNosko merged 7 commits into
masterfrom
MODORDERS-1478-2

Conversation

@RuslanLavrov

@RuslanLavrov RuslanLavrov commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Purpose

Explain why these changes are needed and link the related issue (e.g., https://folio-org.atlassian.net/browse/PROJ-123).

Approach

Provide a brief technical summary of the changes.

Pre-Review Checklist

  • Self-reviewed Code — Reviewed code for issues, unnecessary parts, and overall quality.
  • Change Notes — NEWS.md updated with clear description and issue key.
  • Testing — Confirmed changes were tested locally or on dev environment.
  • Logging: Confirmed that logging is appropriately handled.
  • Breaking Changes — Handled all required actions if changes affect API, DB, or interface versions.
    • API/schema changes
    • Interface version updates
    • DB schema changes / migration scripts
  • New Properties / Environment Variables — Updated README.md if new configs were added.

SerhiiNosko and others added 2 commits November 12, 2026 10:39
@SerhiiNosko @claude
MODORDERS-1478. Make SYSTEM_USER_ENABLED non-essential in DeployConfig
99d5998 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SerhiiNosko @claude
MODORDERS-1478. Make ENV essential in DeployConfig
846c954 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RuslanLavrov
RuslanLavrov requested a review from a team as a code owner November 13, 2026 09:32
SerhiiNosko and others added 2 commits November 13, 2026 13:38
@SerhiiNosko @claude
MODORDERS-1478. Set -Dhttp.port=8082 in DeployConfig JVM options
a06252b 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SerhiiNosko @claude
MODORDERS-1478. Add DB_HOST_READER and DB_PORT_READER to DeployConfig
945f794 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SerhiiNosko and others added 3 commits November 13, 2026 15:07
@SerhiiNosko @claude
MODORDERS-1478. Make sidecar ENV essential and JAVA_OPTS non-essentia…
ff310a3 
…l in DeployConfig

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SerhiiNosko @claude
MODORDERS-1478. Rename JAVA_OPTS to JAVA_OPTIONS, remove sidecar JAVA…
a3c15b5 
…_OPTS and add Bugfest disclaimer in DeployConfig

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SerhiiNosko @claude
MODORDERS-1478. Add RMB connection pool DB variables to DeployConfig
73ef769 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SerhiiNosko SerhiiNosko added the ai label Nov 13, 2026
@SerhiiNosko
SerhiiNosko merged commit 9f62760 into master Nov 13, 2026
16 checks passed
@SerhiiNosko
SerhiiNosko deleted the MODORDERS-1478-2 branch November 13, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes
+1 more reviewer
@ksenchenko ksenchenko ksenchenko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ai

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RuslanLavrov @SerhiiNosko @ksenchenko