Skip to content

Fix Refresh Token Rotation.#2884

Open
brandonpage wants to merge 1 commit into
forcedotcom:devfrom
brandonpage:fix-rtr
Open

Fix Refresh Token Rotation.#2884
brandonpage wants to merge 1 commit into
forcedotcom:devfrom
brandonpage:fix-rtr

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

1 Warning
⚠️ libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L109 - Do not place Android context classes in static fields (static reference to UserAccountManager which has field context pointing to Context); this is a memory leak

Generated by 🚫 Danger

Copy link
Copy Markdown
Contributor

@JohnsonEricAtSalesforce JohnsonEricAtSalesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.13%. Comparing base (7d8d3a0) to head (b5bcc3b).
⚠️ Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...sforce/androidsdk/accounts/UserAccountManager.java 0.00% 4 Missing ⚠️
.../com/salesforce/androidsdk/rest/ClientManager.java 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (16.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2884      +/-   ##
============================================
+ Coverage     55.06%   55.13%   +0.06%     
- Complexity     2496     2501       +5     
============================================
  Files           226      226              
  Lines         17752    17759       +7     
  Branches       2316     2324       +8     
============================================
+ Hits           9775     9791      +16     
+ Misses         6978     6966      -12     
- Partials        999     1002       +3     
Components Coverage Δ
Analytics 48.71% <ø> (ø)
SalesforceSDK 41.85% <17.50%> (+0.14%) ⬆️
Hybrid 59.30% <ø> (ø)
SmartStore 78.19% <ø> (-0.02%) ⬇️
MobileSync 82.10% <ø> (-0.01%) ⬇️
React 51.50% <ø> (ø)
Files with missing lines Coverage Δ
.../com/salesforce/androidsdk/rest/ClientManager.java 62.06% <50.00%> (+0.44%) ⬆️
...sforce/androidsdk/accounts/UserAccountManager.java 62.57% <0.00%> (-0.80%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants