Add UI tests for refresh token rotation#4034
Closed
wmathurin wants to merge 44 commits into
Closed
Conversation
Bump to iOS 18 and add corresponding Claude skill
Switch to #Preview macro for SwiftUI views
…e-update Update UI Tests for login screen changes.
- Remove SFMobileSyncSyncManager+Instrumentation references from MobileSync.xcodeproj - Remove SFSmartStore+Instrumentation references from SmartStore.xcodeproj Fixes build errors where Xcode was trying to copy deleted header files.
…signpost-support Remove signpost support (W-20481716)
…-warnings Fix compiler warnings in testLoginHostListViewControllerCreatesUniqueInstances
Add Login for Admin feature.
Remove deprecated code
Update SQLCipher to 4.15.0 and add skill
* Add public API to trigger Login for Admin flow. * Improve code documentation for loginViewControllerDidSelectLoginForAdmin.
Putting back SalesforceSDKCommon
Merge master into dev
Add foregroundRegistrationMode enum to re-register all users on app foreground
Update SQLCipher to 4.16.0
- Add eca_jwt_rtr and eca_opaque_rtr to KnownAppConfig enum in UITestConfigUtils - Add AppConfig.isRtr computed property (mirrors issuesJwt pattern) - Add RTRLoginTests: 8 tests covering hybrid/no-hybrid × jwt/opaque RTR apps, with and without app restart - assertRevokeAndRefreshWorks now asserts refresh token rotates for RTR apps and stays stable for non-RTR apps - Update ui_test_config.json.sample with eca_jwt_rtr and eca_opaque_rtr entries
Generated by 🚫 Danger |
wmathurin
changed the title
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||
|
||||||||||||||
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4034 +/- ##
==========================================
+ Coverage 63.35% 68.22% +4.86%
==========================================
Files 250 245 -5
Lines 21659 21457 -202
==========================================
+ Hits 13723 14639 +916
+ Misses 7936 6818 -1118
🚀 New features to boost your workflow:
|
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||||||
|
||||||||||||||
|
||||||||||||||||||
|
||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RTRLoginTests— 8 UI tests covering ECA apps with Refresh Token Rotation (RTR) enabled, across hybrid/non-hybrid flows and with/without app restartassertRevokeAndRefreshWorksnow asserts the refresh token rotates after a revoke/refresh cycle for RTR apps, and stays stable for non-RTR appsecaOpaqueRtrandecaJwtRtrtoKnownAppConfigandAppConfig.isRtrcomputed property inUITestConfigUtilsui_test_config.json.samplewith the two new RTR app entriesoverview.mdto document the new test class and app configsKnown failures — W-22512846
testECAJwtRtr_HybridandtestECAJwtRtr_Hybrid_WithRestartare expected to fail until W-22512846 (Enable Named JWTs for Hybrid Flows) is resolved on the server side.The server currently returns
invalid_grantwhen RTR is used with JWT-based access tokens in hybrid flow. The four non-hybrid and opaque RTR tests are expected to pass.