Prepare command upgraded ssc#1025
Open
mneeta wants to merge 4 commits into
Open
Conversation
- Add SynchronizationResult class to track tag sync status and system-managed flag - Implement /internalCustomTags fallback for Aviator built-in tags detection - Update prepare command to skip manual association for system-managed tags - Preserve DAST correlation tag and last_correlation attribute behavior - Fix AviatorLoggerImpl.warn() to output warnings to console (stderr) - Update help text to explain SSC 26.2+ behavior - Add unit tests for SynchronizationResult and PrepareResult
rsenden
requested changes
Jun 4, 2026
| JsonNode predictionTag = tagHelperPrediction.synchronize(result); | ||
| JsonNode statusTag = tagHelperStatus.synchronize(result); | ||
| JsonNode dastCorrTag = tagHelperDastCorr.synchronize(result); | ||
| SynchronizationResult predictionResult = tagHelperPrediction.synchronize(result); |
Contributor
There was a problem hiding this comment.
This method is quite long; can this be split into multiple methods?
| exist in SSC and are associated with the specified issue templates and/or application versions. \ | ||
| This is necessary to prevent SSC from stripping Fortify Remediation Aviator audit data from uploaded FPR files. \ | ||
| At least one update option must be specified. \ | ||
| %n%nFor SSC 26.2 and later, Aviator tags are built-in system-managed tags that are automatically associated with all \ |
Contributor
There was a problem hiding this comment.
I think it was mentioned that these system-managed tags are only available if Aviator is enabled in SSC configuration, correct? If so, would be good to explicitly mention this in fcli usage help.
| * @param result the prepare result to record status entries | ||
| * @return SynchronizationResult indicating success/failure and whether system-managed | ||
| */ | ||
| public SynchronizationResult synchronize(AviatorSSCPrepareHelper.PrepareResult result) { |
Contributor
There was a problem hiding this comment.
This method seems fairly long; please check whether it's feasible to refactor into multiple focused methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds capability detection for SSC 26.2+ system-managed Aviator tags.
Changes