Skip to content

feat: Add --force-delete option to sc-dast scan delete #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilseara wants to merge 2 commits into
base: dev/v3.x
Choose a base branch
from
+31 −5
Open

feat: Add --force-delete option to sc-dast scan delete #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40aa4e4
feat: Add --force-delete option to sc-dast scan delete command
Apr 1, 2026
4140294
fix: Use Map instead of kong.unirest.core type for query parameters
Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions ...ain/java/com/fortify/cli/sc_dast/scan/cli/cmd/action/AbstractSCDastScanActionCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
*/
package com.fortify.cli.sc_dast.scan.cli.cmd.action;

import java.util.Collections;
import java.util.Map;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ObjectNode;
Expand Down Expand Up @@ -43,12 +46,21 @@ public final JsonNode getJsonNode() {
SCDastScanDescriptor descriptor = scanResolver.getScanDescriptor(unirest);
ObjectNode body = new ObjectMapper().createObjectNode()
.put("scanActionType", getAction().name());
unirest.post("/api/v2/scans/{id}/scan-action")
.routeParam("id", descriptor.getId())
.body(body)
var request = unirest.post("/api/v2/scans/{id}/scan-action")
.routeParam("id", descriptor.getId());
getQueryParameters().forEach(request::queryString);
request.body(body)
.asString().getBody(); // TODO Does SC DAST return proper HTTP codes if there are any errors, or should we parse the response?
return descriptor.asJsonNode();
}

/**
* Subclasses can override this method to provide additional query parameters
* for the scan-action request.
*/
protected Map<String, Object> getQueryParameters() {
return Collections.emptyMap();
}

@Override
public final String getActionCommandResult() {
Expand Down
18 changes: 16 additions & 2 deletions ...st/src/main/java/com/fortify/cli/sc_dast/scan/cli/cmd/action/SCDastScanDeleteCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,32 @@
*/
package com.fortify.cli.sc_dast.scan.cli.cmd.action;

import java.util.Collections;
import java.util.Map;

import com.fortify.cli.common.output.cli.mixin.OutputHelperMixins;

import lombok.Getter;
import picocli.CommandLine.Command;
import picocli.CommandLine.Mixin;
import picocli.CommandLine.Option;

@Command(name = OutputHelperMixins.Delete.CMD_NAME)
public class SCDastScanDeleteCommand extends AbstractSCDastScanActionCommand {
@Getter @Mixin private OutputHelperMixins.Delete outputHelper;

@Getter @Mixin private OutputHelperMixins.Delete outputHelper;
@Option(names = {"--force-delete", "-f"}, description = "Force deletion of the scan by adding forceDelete=true query parameter")
private boolean forceDelete;

@Override
protected SCDastScanAction getAction() {
return SCDastScanAction.DeleteScan;
}

@Override
protected Map<String, Object> getQueryParameters() {
if (forceDelete) {
return Map.of("forceDelete", "true");
}
return Collections.emptyMap();
}
}
Loading