Repository navigation
feat(claude): fleet-lsp for the review agents' LSP - #17
Merged
Merged
Conversation
Enable the rust-analyzer, typescript and pyright LSP plugins beside gopls, and give the four code-reading reviewers (implementation-review, plan-review-backend/architect/language) the LSP tool, with one paragraph on when to use it and why an empty answer proves nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 6 (a) of fleet-lsp's plan: the Brewfile installs fredericrous/tap/fleet-lsp and typescript-language-server, and Claude Code knows the fleet-lsp marketplace, read from its release branch. The official LSP plugins stay on until (b), so a failed install never leaves a machine without language servers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 6 (b), after fleet-lsp doctor exits 0 in relais and authelia-oidc-operator with the tap-installed 0.1.0: fleet-lsp@fleet-lsp on, the official gopls/rust-analyzer/typescript/pyright plugins off. The reviewers' note now says what fleet-lsp guarantees: answers only from the pinned server once it has loaded, errors that name cause and fix. Rollback: revert this commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Implementation review: a pyright or typescript-language-server version fleet-lsp has not measured gets no readiness barrier, and the Brewfile does not pin the adapter (Homebrew ships the measured 6.0.1 today). The reviewers' note now says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fredericrous
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the four code-reading reviewers (
implementation-review,plan-review-backend,-architect,-language) theLSPtool, served by fleet-lsp — Phase 6 of fleet-lsp's plan (pointer:docs/plans/2026-10-06-fleet-lsp-pinned-ready-language-servers.md).Commits
bf72b92— first version of this PR: official LSP plugins on,LSPtool + a usage paragraph for the four reviewers.11975fe(a) — install, nothing switched: Brewfilefredericrous/tap/fleet-lsp+typescript-language-server;extraKnownMarketplaces.fleet-lspread from itsreleasebranch. Official plugins stay on.d2180b2(b) — the switch:fleet-lsp@fleet-lspon, officialgopls/rust-analyzer/typescript/pyrightLSP plugins off; the note says what fleet-lsp guarantees.e947e73— review: the note keeps fleet-lsp's narrowed case (an unmeasured pyright/TS adapter version).Rollback: revert
e947e73, thend2180b2— the official plugins come back on.Verification
releasebranch = v0.1.0);brew install fredericrous/tap/fleet-lsp→ 0.1.0;fleet-lsp doctorexit 0 in relais and authelia-oidc-operator. Recorded in fleet-lsp's plan (fleet-lsp#2).make checkgreen after each commit.chezmoi apply: a fresh session installs fleet-lsp from the release ref and answers with the official plugins off — to be observed and recorded in fleet-lsp's plan.🤖 Generated with Claude Code