add new method for disabling ability to log in via ssh with password;…#46
Open
lukasz-piotrowski-fujitsu wants to merge 1 commit intodevelopmentfrom
Open
add new method for disabling ability to log in via ssh with password;…#46lukasz-piotrowski-fujitsu wants to merge 1 commit intodevelopmentfrom
lukasz-piotrowski-fujitsu wants to merge 1 commit intodevelopmentfrom
Conversation
Collaborator
Author
|
Implementation checked on New3 environment; tests succeeded; details in ADO, task 3147 |
lukasz-piotrowski-fujitsu
requested review from
a user,
AnjriI,
adriangawinek,
fujitsu-domzalskis and
wilkowskia
| // DisableSSHLogin disables SSH login via password by extending cloud config | ||
| func (sc *StandardCfgManager) DisableSSHLogin() error { | ||
|
|
||
| disableSshLoggingViaPassword := []CloudConfigItem{ |
Collaborator
There was a problem hiding this comment.
Trivial, rename for readability:
Suggested change
| disableSshLoggingViaPassword := []CloudConfigItem{ | |
| disableSshPasswordAuthentication := []CloudConfigItem{ |
Collaborator
|
As discussed in private chat - let's check if we can simplify this mechanism by introduction of structure serializing to YAML. This solution probably works but it became quite complicated so we might want to look for another concept. |
lukasz-piotrowski-fujitsu
removed request for
a user,
AnjriI,
adriangawinek and
wilkowskia
lukasz-piotrowski-fujitsu
force-pushed
the
task/3147
branch
from
2496264 to
85c72c8
Compare
add constructor for cloudInitFile struct with optional params; cloudInitFile constructor returns error if verification fails; add unit tests;
lukasz-piotrowski-fujitsu
force-pushed
the
task/3147
branch
from
85c72c8 to
e2f2228
Compare
lukasz-piotrowski-fujitsu
requested review from
a user,
AnjriI,
adriangawinek,
fujitsu-domzalskis and
wilkowskia
Collaborator
Author
|
New approach with casting cloud-config.yaml to a custom struct, tested on the test environment and production one (New3). Tests succeeded; details in task 3147 on ADO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.