feat: Gigahdx liquidations#1460
Draft
enthusiastmartin wants to merge 15 commits into
Draft
Conversation
|
Crate versions that have not been updated:
Crate versions that have been updated:
hydradx-runtime: cargo and spec versions don't match. Runtime version has been increased. |
feat: add claude skill and reference docs
dmoka
reviewed
May 29, 2026
| fn clear_conflicting_votes(who: &AccountId, max_remaining_hdx: Balance) -> Result<u32, DispatchError>; | ||
|
|
||
| /// Saturating reduction of the `pyconvot` lock by `amount`. | ||
| fn force_release_vote_lock(who: &AccountId, amount: Balance) -> Result<(), DispatchError>; |
Contributor
There was a problem hiding this comment.
i dont see this used in any prod code, is it intentional or we have some missing usage?
dmoka
reviewed
May 29, 2026
| /// Emits `Liquidated` event when successful. | ||
| /// | ||
| #[pallet::call_index(0)] | ||
| // Worst case is the gigahdx branch: up to 3 full-gas EVM calls |
Contributor
There was a problem hiding this comment.
not sure if this is the best way to handle the benchmark of worst case.
In the current liqudate benchmark test, we use collateral asset hdx.
I see 2 options:
- either we use gigahdx as collateral asset so we properly have the worst case here
- or we introduce a new benchmark test for gigahdx branch, then in the weight macro we switch to it if collateral asset is gigahdx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.