feat: signed dispatch permit#1462
Merged
Merged
Conversation
|
Crate versions that have been updated:
Runtime version has been increased. |
mrq1911
approved these changes
May 29, 2026
Member
mrq1911
left a comment
mrq1911
left a comment
There was a problem hiding this comment.
Reviewed the signed dispatch-permit logic. The signed branch correctly charges the paymaster (Substrate envelope fee always, EVM gas only on success — failed inner calls roll back via the per-call storage layer), the dry-run removal and 1× weight are correct, and the fee-payer override is restored on every path. Tests cover the key behaviors (nonce rollback on revert, no autopause on the signed path, fee-payer restore). LGTM.
|
Quick benchmark at commit 4c93712 has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1458
todo: