fix gossip topic scoring#58
Merged
Merged
Conversation
added 2 commits
May 29, 2026 15:35
alexX512
reviewed
May 29, 2026
| } | ||
|
|
||
| fn on_disconnected(&mut self, conn: usize, now: Instant, emit: &mut impl FnMut(PeerControl)) { | ||
| tracing::debug!("removing disconnected peer: {conn}"); |
Contributor
There was a problem hiding this comment.
Btw can we set in CI tests higher level of tracing? Looks like now they run for 12 mins and amount of logs increased
ninaiiad
reviewed
May 29, 2026
| } | ||
| // Archived copy is written on the normal disconnect path fired | ||
| // downstream once the Ban takes effect; here we just drop live. | ||
| // downstream once the Ban takes ffect; here we just drop live. |
alexX512
approved these changes
May 29, 2026
ninaiiad
reviewed
May 29, 2026
|
|
||
| // P3 — deficit below expected delivery rate, squared | ||
| mesh_message_deliveries_threshold: 20.0, | ||
| // P3 — deficit below expected delivery rate, squared. |
Collaborator
There was a problem hiding this comment.
is P3 a Phase 3 of some implementation task? how well does this notation age?
Collaborator
Author
There was a problem hiding this comment.
comes from spec
ninaiiad
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
threshold was wrong for topics that average 1 msg per slot + scoring decay interval was too fast