Conversation
alexX512
reviewed
May 29, 2026
| f.epoch.state.deposit_balance_to_consume = u64::MAX / 2; | ||
| for (i, (pk, creds, effective_balance, balance, act, exit)) in validators.iter().enumerate() | ||
| { | ||
| f.validators.pubkey_slice_mut()[i] = *pk; |
Contributor
There was a problem hiding this comment.
Looks like decompressed pubkeys missed. Might be we can move that to constructor of validators and use data.append function, which automatically create decompressed pubkey + add to index as it is less error prone
Also I think it is better not to give mut API for finalized data in general, only constructors + promote API can prevent lots of errors
vladimir-ea
reviewed
May 29, 2026
| finalized_validators, | ||
| pending_pool, | ||
| pending_pool_next: 1, | ||
| state: BeaconStateOwner::new(BeaconState::default()), |
Collaborator
There was a problem hiding this comment.
I think we will need to pass the BeaconStateOwner by construction b/c other tiles will need readers and and readers are created from the owner.
alexX512
approved these changes
May 29, 2026
vladimir-ea
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.