Repository navigation
add api.ExpectContains struct - #20
Merged
Merged
Conversation
jaypipes
force-pushed
the
expect-contains
branch
from
October 19, 2026 19:33
1f4d67b to
bad8fe1
Compare
Adds a new common `api.ExpectContains` struct that replaces the `plugin/exec.PipeExpect` struct and can be used in other gdt plugins. For example, the kube plugin has been modified to use this new `ExpectContains` struct instead of a plain string field for its `Expect.Error` field. Also updates the documentation and parsing/tests for the `require` object compared to the `assert` object. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
force-pushed
the
expect-contains
branch
from
October 19, 2026 19:37
bad8fe1 to
5086125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new common
api.ExpectContainsstruct that replaces theplugin/exec.PipeExpectstruct and can be used in other gdt plugins. For example, the kube plugin has been modified to use this newExpectContainsstruct instead of a plain string field for itsExpect.Errorfield.Also updates the documentation and parsing/tests for the
requireobject compared to theassertobject.