Repository navigation
fix(browser-automation): restore session recovery error guidance - #7371
Open
bb-slop-cop[bot] wants to merge 2 commits into
Open
bb-slop-cop[bot] wants to merge 2 commits into
bb-slop-cop[bot] wants to merge 2 commits into
Conversation
…_unavailable Match "open a new session", which every session-loss producer includes, so "Browser session stopped; open a new session" (browser crash or preview loss) also gets the reopen hint. Timeouts keep the extra --timeout advice. Document the broadened classification in the skill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The browser automation CLI recognized only one stopped/expired error phrasing. Other errors emitted by its host and process implementation fell through to
command_failed, omitting session recovery guidance. Cancellation and timeout close the session, so those failures also need the reopen hint.Report: https://get-bb.github.io/reports/issues/7349.html — REPRODUCED, high confidence, repeated by the same investigator in two clean checkouts at
7c1353d80729983b86ea1555d18b42407f320406.What changed
session_unavailablewith reopen guidance; cancellation/timeout additionally suggests the existing--timeoutoption and 120-second ceiling.git diff --numstat origin/main.How you verified
pnpm exec turbo run test --filter=bb-plugin-browser-automation -- cli.test.tsfailed in the same three cases:command_failedinstead ofsession_unavailable, without a recovery hint; 11 other cases passed.pnpm exec turbo run test lint typecheck --filter=bb-plugin-browser-automationpassed: 106 tests across 8 files, plus lint and typecheck.pnpm exec turbo run build --filter=@get-bb/plugin-sdkandpnpm exec turbo run build --filter=bb-plugin-browser-automationpassed.git diff --checkpassed; all changed files are text.Fixes #7349