Skip to content

Setup guide: wait for this computer before loading install info, and send each step's load event once - #7408

Open
brsbl wants to merge 2 commits into
bb/fix-first-run-setup-guide-failures-thr_t3igch32nefrom
bb/fix-setup-guide-review-follow-ups-thr_vt8m377k5q
Open

brsbl wants to merge 2 commits into
bb/fix-first-run-setup-guide-failures-thr_t3igch32nefrom
bb/fix-setup-guide-review-follow-ups-thr_vt8m377k5q

Conversation

@brsbl

@brsbl brsbl commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The new setup guide asked for agent install info as soon as it opened, before this computer had connected. Separately, each step kept its own load timer, so reopening a step sent another load-success event with a near-zero time.

What changed

  • The new guide waits for this computer to connect before loading agent install info.
  • Each step sends one load-success event per guide run.
  • That event's time now runs from when the step first opened.

How you verified

  • Remote CI passed. Run
  • New tests cover both fixes: the gate waits for a connected computer, and reopening a step sends no second event.
  • Opened the new guide with this computer offline: no install-info request was sent until it connected.
  • Moved back and forth between steps: two load events (one per step) instead of four.

BB-Thread-ID: thr_vt8m377k5q

AGENT GENERATED

🤖 Generated with Claude Code

@brsbl brsbl changed the title Wait for this computer before the setup guide loads install info, and report each step's load once Setup guide: wait for this computer before loading install info, and send each step's load event once Nov 11, 2026
@brsbl
brsbl marked this pull request as ready for review November 11, 2026 01:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T01:36:20.929499Z d84056a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brsbl
brsbl force-pushed the bb/fix-setup-guide-review-follow-ups-thr_vt8m377k5q branch from d84056a to 36da825 Compare November 11, 2026 01:57
@brsbl
brsbl force-pushed the bb/fix-first-run-setup-guide-failures-thr_t3igch32ne branch from a59d3a0 to 184d0c3 Compare November 11, 2026 03:14
brsbl and others added 2 commits November 10, 2026 19:37
…info, and report each step's load once per guide run

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@brsbl
brsbl force-pushed the bb/fix-setup-guide-review-follow-ups-thr_vt8m377k5q branch from 36da825 to 54458d8 Compare November 11, 2026 03:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant